Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bool timer implementation in WIN32 #1850

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Fix bool timer implementation in WIN32 #1850

merged 1 commit into from
Mar 5, 2021

Conversation

josesimoes
Copy link
Member

Description

  • Replace HAL_COMPLETION implementation with timer.

Motivation and Context

  • Bool timers wheren't working on WIN32.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot nfbot added the Type: bug label Mar 5, 2021
@josesimoes josesimoes added the Platform: Virtual Device & WIN32 Everything related specifically with WIN32 and .NET tool builds label Mar 5, 2021
@josesimoes josesimoes merged commit ff3f1ef into nanoframework:develop Mar 5, 2021
@josesimoes josesimoes deleted the fix-bool-time-win32 branch March 5, 2021 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Platform: Virtual Device & WIN32 Everything related specifically with WIN32 and .NET tool builds Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot